Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-28629: Upgrade dind in precommit #5546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HIVE-28629: Upgrade dind in precommit #5546

wants to merge 1 commit into from

Conversation

abstractdog
Copy link
Contributor

@abstractdog abstractdog commented Nov 15, 2024 •
edited
Loading

What changes were proposed in this pull request?

Upgrade dind version.

Why are the changes needed?

Due to incompatibility issues.

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

No.

How was this patch tested?

Precommit picks up the new Jenkinsfile, so this is tested.

@abstractdog
Copy link
Contributor Author

https://ci.hive.apache.org/job/hive-precommit/job/PR-5546/1/console

Obtained Jenkinsfile from 1bbfb42d49ed86b023e6706be534a2c6e21b5b9f

@abstractdog abstractdog changed the title HIVE-28629: hive-precommit job runs shows that precommit runs on external repository's Jenkinsfile - trying to upgrade dind HIVE-28629: Upgrade dind in precommit Nov 15, 2024
@abstractdog
Copy link
Contributor Author

abstractdog commented Nov 15, 2024 •
edited
Loading

there is a port mismatch in the first revision, taking care of that:

2376 vs 2375

from dind:

│ time="2024-11-15T09:40:00.366878279Z" level=info msg="API listen on /var/run/docker.sock"                                                                                                                                                                  │
│ time="2024-11-15T09:40:00.372866219Z" level=info msg="API listen on :2376"

from hive-dev-box:

jenkins@hive-precommit-pr-5546-1-klq14-z6tnc-xr3h7:~$ docker run --rm --name qtestExternalDB-MySQLExternalDB -p 3306:3306 -e MYSQL_ROOT_PASSWORD=qtestpassword -e MYSQL_DATABASE=qtestDB -d mysql:8.4.3
docker: Cannot connect to the Docker daemon at tcp://localhost:2375. Is the docker daemon running?.
See 'docker run --help'.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abstractdog @asf-ci-hive